feat(core): migrate to allowedOriginPatterns for credentialed CORS#46
Closed
OmarAitBenaissa wants to merge 2 commits into
Closed
feat(core): migrate to allowedOriginPatterns for credentialed CORS#46OmarAitBenaissa wants to merge 2 commits into
OmarAitBenaissa wants to merge 2 commits into
Conversation
|
|
OmarAitBenaissa
force-pushed
the
feat/Update-cors-configuration-to-allowedPatterns-origins
branch
from
a46247f to
1b30789
Compare
brandPittCode
requested changes
May 12, 2026
… prevent wildcard + credentials conflicts and allows controlled subdomain matching. Signed-off-by: OmarAitBenaissa <omar.aitbenaissa.partner@decathlon.com>
…enhance security with allowedOriginPatterns Signed-off-by: OmarAitBenaissa <omar.aitbenaissa.partner@decathlon.com>
OmarAitBenaissa
force-pushed
the
feat/Update-cors-configuration-to-allowedPatterns-origins
branch
from
491c969 to
a94ce8a
Compare
|
brandPittCode
approved these changes
May 12, 2026
OmarAitBenaissa
deleted the
feat/Update-cors-configuration-to-allowedPatterns-origins
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This pull request updates the application's CORS configuration to use
allowed-origin-patternsandallowed-origins, aligning with more flexible and modern Spring CORS configuration practices. The change ensures that origin matching can use patterns (such as wildcards), which is more robust for various deployment scenarios.What this PR Provides
CORS Configuration Updates:
CorsPropertiesrecord to useallowedOriginPatternsandallowedOrigins, and updated the null check accordingly (CorsProperties.java).corsConfigurationSourcebean to callsetAllowedOriginPatternsinstead ofsetAllowedOrigins(SecurityConfiguration.java).Configuration File Adjustments:
application.ymlto use theallowed-origin-patternsproperty and its corresponding environment variable, replacingallowed-origins(application.yml).… prevent wildcard + credentials conflicts and allows controlled subdomain matching.Review
The reviewer must double-check these points: